Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asserting checkbox checked state? #39

Closed
lolmaus opened this issue Feb 27, 2019 · 6 comments
Closed

Asserting checkbox checked state? #39

lolmaus opened this issue Feb 27, 2019 · 6 comments

Comments

@lolmaus
Copy link
Contributor

lolmaus commented Feb 27, 2019

Currently doing this:

expect(checkbox.checked).to.be.true;

I believe, it would read much better as:

expect(checkbox).to.be.checked;

CC @simonihmig
@lolmaus
Copy link
Contributor Author

lolmaus commented Nov 12, 2021

Please??

@nathanboktae
Copy link
Owner

I like it - I'll accept a PR for the feature!

@lolmaus
Copy link
Contributor Author

lolmaus commented Nov 12, 2021

Can you please provide some guidance?

@nathanboktae
Copy link
Owner

See #53 - prime example of adding a new assertion with documentation and tests.

@lolmaus lolmaus mentioned this issue Nov 26, 2021
Merged
@lolmaus
Copy link
Contributor Author

lolmaus commented Nov 26, 2021

Done: #56 .

nathanboktae added a commit that referenced this issue Nov 27, 2021
@nathanboktae
Merge pull request #56 from lolmaus/feature/39-checked
1bffc6d 
Add checked assertion, fixes #39
@lolmaus
Copy link
Contributor Author

lolmaus commented Nov 28, 2021

@nathanboktae Thanks! Are you gonna release it?

@0nlyP2P 0nlyP2P mentioned this issue May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lolmaus @nathanboktae