Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the checked assertion #60198

Merged
merged 3 commits into from May 9, 2022
Merged

Conversation

0nlyP2P
Copy link
Contributor

@0nlyP2P 0nlyP2P commented May 5, 2022

They added a checked Assertion as requested in this issue:
nathanboktae/chai-dom#39

Documentation:
https://github.com/nathanboktae/chai-dom#checked

@typescript-bot
Copy link
Contributor

typescript-bot commented May 5, 2022

@Wagner-Daniel Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60198,
  "author": "wagner-daniel",
  "headCommitOid": "bb3d2d46af627583482eadcfb62ca69a402cd110",
  "mergeBaseOid": "ec3525c11ef9f60e731b9a0e9bd64bfc4bf9fdab",
  "lastPushDate": "2022-05-08T16:49:27.000Z",
  "lastActivityDate": "2022-05-09T09:33:44.000Z",
  "mergeOfferDate": "2022-05-08T19:07:29.000Z",
  "mergeRequestDate": "2022-05-09T09:33:44.000Z",
  "mergeRequestUser": "mattlewis92",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "chai-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/chai-dom/chai-dom-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/chai-dom/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mattlewis92"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "mattlewis92",
      "date": "2022-05-09T09:33:35.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "joshuajeschek",
      "date": "2022-05-08T19:06:50.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1118453460,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label May 5, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 5, 2022
@typescript-bot
Copy link
Contributor

🔔 @mattlewis92 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 5, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board May 5, 2022
@typescript-bot
Copy link
Contributor

@Wagner-Daniel The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 5, 2022
@typescript-bot typescript-bot removed Owner Approved A listed owner of this package signed off on the pull request. The CI failed When GH Actions fails Untested Change This PR does not touch tests labels May 8, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board May 8, 2022
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 8, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board May 8, 2022
@typescript-bot
Copy link
Contributor

@Wagner-Daniel The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label May 8, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board May 8, 2022
@typescript-bot
Copy link
Contributor

@mattlewis92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Contributor

@joshuajeschek joshuajeschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 8, 2022
@typescript-bot
Copy link
Contributor

@Wagner-Daniel: Everything looks good here. I am ready to merge this PR (at bb3d2d4) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mattlewis92: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 8, 2022
@mattlewis92
Copy link
Contributor

Ready to merge

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 9, 2022
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 9, 2022
@typescript-bot typescript-bot merged commit 8ef81a4 into DefinitelyTyped:master May 9, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants