forked from vercel/next.js
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug fix: dynamic page should not be interpreted as predefined page (v…
…ercel#33808) Fixes: vercel#17096 Fixes: vercel#23824 Closes: vercel#33765 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added in vercel#33765 - [x] Errors have helpful link attached (N/A) Co-authored-by: Tim Neutkens <6324199+timneutkens@users.noreply.github.com> Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
- Loading branch information
Showing
2 changed files
with
76 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import { createNext } from 'e2e-utils' | ||
import { NextInstance } from 'test/lib/next-modes/base' | ||
import { renderViaHTTP } from 'next-test-utils' | ||
import cheerio from 'cheerio' | ||
|
||
describe('Dynamic Route Interpolation', () => { | ||
let next: NextInstance | ||
|
||
beforeAll(async () => { | ||
next = await createNext({ | ||
files: { | ||
'pages/blog/[slug].js': ` | ||
export function getServerSideProps({ params }) { | ||
return { props: { slug: params.slug } } | ||
} | ||
export default function Page(props) { | ||
return <p id="slug">{props.slug}</p> | ||
} | ||
`, | ||
|
||
'pages/api/dynamic/[slug].js': ` | ||
export default function Page(req, res) { | ||
const { slug } = req.query | ||
res.end('slug: ' + slug) | ||
} | ||
`, | ||
}, | ||
dependencies: {}, | ||
}) | ||
}) | ||
afterAll(() => next.destroy()) | ||
|
||
it('should work', async () => { | ||
const html = await renderViaHTTP(next.url, '/blog/a') | ||
const $ = cheerio.load(html) | ||
expect($('#slug').text()).toBe('a') | ||
}) | ||
|
||
it('should work with parameter itself', async () => { | ||
const html = await renderViaHTTP(next.url, '/blog/[slug]') | ||
const $ = cheerio.load(html) | ||
expect($('#slug').text()).toBe('[slug]') | ||
}) | ||
|
||
it('should work with brackets', async () => { | ||
const html = await renderViaHTTP(next.url, '/blog/[abc]') | ||
const $ = cheerio.load(html) | ||
expect($('#slug').text()).toBe('[abc]') | ||
}) | ||
|
||
it('should work with parameter itself in API routes', async () => { | ||
const text = await renderViaHTTP(next.url, '/api/dynamic/[slug]') | ||
expect(text).toBe('slug: [slug]') | ||
}) | ||
|
||
it('should work with brackets in API routes', async () => { | ||
const text = await renderViaHTTP(next.url, '/api/dynamic/[abc]') | ||
expect(text).toBe('slug: [abc]') | ||
}) | ||
}) |