Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RTD builds; pip install gdal failures #1576

Merged
merged 4 commits into from
May 10, 2024
Merged

Fix RTD builds; pip install gdal failures #1576

merged 4 commits into from
May 10, 2024

Conversation

davemfish
Copy link
Contributor

@davemfish davemfish commented May 10, 2024 •
edited

Using RTD recommended build.jobs steps to more explicitly control how we use pip.

Fixes #1575

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@davemfish davemfish changed the title use pip-upgrade-only-if-needed flag. #1575 Fix RTD builds; pip install gdal failures May 10, 2024
@davemfish davemfish marked this pull request as ready for review May 10, 2024 18:14
@davemfish davemfish requested a review from phargogh May 10, 2024 18:14
phargogh
phargogh approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@phargogh phargogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the RTD build worked!

@phargogh phargogh merged commit 98419aa into natcap:main May 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phargogh phargogh phargogh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTD builds failing, trying to pip install gdal
2 participants
@davemfish @phargogh