Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pip packages in package_versions.txt #1573

Merged
merged 1 commit into from
May 10, 2024

Conversation

davemfish
Copy link
Contributor

package_versions.txt is meant to be a list of all packages & versions included in the binary builds. It's a convenient way to see which version of package was bundled with the workbench, after the workbench is installed.

We were building it with micromamba list, but that excludes pip installed packages (pygeoprocessing, taskgraph, among others). I did not find any way for micromamba to include these, so I appended the pip list to the micromamba list. There is some overlap, which I don't understand, but I think that's okay given the purpose of this file.

Fixes #1527

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@davemfish davemfish marked this pull request as ready for review May 10, 2024 15:58
@davemfish davemfish requested a review from emlys May 10, 2024 15:58
@davemfish davemfish added this to the 3.14.2 milestone May 10, 2024
Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davemfish this makes sense, I just had a couple of questions. Is package_versions.txt a standard thing? I assumed it was but I couldn't find anything about it online.

And, if the intent is to list all the package versions used in the binary builds, would it make sense to get that info from Pyinstaller somehow? Since Pyinstaller should know what is actually included in the package.

@davemfish
Copy link
Contributor Author

@davemfish this makes sense, I just had a couple of questions. Is package_versions.txt a standard thing? I assumed it was but I couldn't find anything about it online.

And, if the intent is to list all the package versions used in the binary builds, would it make sense to get that info from Pyinstaller somehow? Since Pyinstaller should know what is actually included in the package.

@emlys the Pyinstaller idea is a good one, I hadn't thought of that. As far as I know package_versions.txt is just something we do for our own info, but I don't know the origin of it.

@davemfish
Copy link
Contributor Author

@davemfish this makes sense, I just had a couple of questions. Is package_versions.txt a standard thing? I assumed it was but I couldn't find anything about it online.
And, if the intent is to list all the package versions used in the binary builds, would it make sense to get that info from Pyinstaller somehow? Since Pyinstaller should know what is actually included in the package.

@emlys the Pyinstaller idea is a good one, I hadn't thought of that. As far as I know package_versions.txt is just something we do for our own info, but I don't know the origin of it.

It looks like we would have to add some custom code to our pyinstaller script to do this. I kinda feel like it's not worth it given how little we actually refer to package_versions.txt.

Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for looking into it!

@emlys emlys merged commit 135e316 into natcap:main May 10, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package_versions.txt is missing some included packages
2 participants