Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues on windows and restore changes from 0.16.1 #106

Merged
merged 3 commits into from Nov 27, 2022
Merged

Commits on Nov 27, 2022

  1. Fix various issues manifesting on windows

    - Make the tests that break on python37 on windows only run for python >= 3.8
    - Reenable disabled test matrix item for windows-python37
    
    In shell tasks:
    - check for sh installed with git
    - trust git bash over bash on the path which might be a decoy put there to trick us
    - add test for the default powershell, as distinct from pwsh
    nat-n committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    a484ac9 View commit details
    Browse the repository at this point in the history
  2. Revert "Revert "PoetryExecutor does not use poetry if POETRY_VIRTUALE…

    …NVS_CREATE=false #65""
    
    This reverts commit e6e162e.
    nat-n committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    d5dde93 View commit details
    Browse the repository at this point in the history
  3. Always explicitly use the poetry virtualenv if possible in the poetry…

    … executor
    
    This removes an optimization that probably does add much value anymore, but
    does seem to cause tasks to be run without the correct virtual_env in some
    scenarios on windows.
    
    Also make process of updaating the path env var to enable a venv try to avoid
    redundant updates in case the virtualenv is already active.
    nat-n committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    f578cdb View commit details
    Browse the repository at this point in the history