Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues on windows and restore changes from 0.16.1 #106

Merged
merged 3 commits into from Nov 27, 2022
Merged

Conversation

nat-n
Copy link
Owner

@nat-n nat-n commented Nov 27, 2022

Fix various issues manifesting on windows

  • Make the tests that break on python37 on windows only run for python >= 3.8
  • Reenable disabled test matrix item for windows-python37
  • In shell tasks:
    • check for sh installed with git
    • trust git bash over bash on the path which might be a decoy put there to trick us
    • add test for the default powershell, as distinct from pwsh

Restore changes from 0.16.1 that were reverted in 0.16.2

Always explicitly use the poetry virtualenv if possible in the poetry executor

Also make process of updating the path env var to enable a venv try to avoid
redundant updates in case the virtualenv is already active.

- Make the tests that break on python37 on windows only run for python >= 3.8
- Reenable disabled test matrix item for windows-python37

In shell tasks:
- check for sh installed with git
- trust git bash over bash on the path which might be a decoy put there to trick us
- add test for the default powershell, as distinct from pwsh
… executor

This removes an optimization that probably does add much value anymore, but
does seem to cause tasks to be run without the correct virtual_env in some
scenarios on windows.

Also make process of updaating the path env var to enable a venv try to avoid
redundant updates in case the virtualenv is already active.
@nat-n nat-n merged commit 726c766 into development Nov 27, 2022
@nat-n nat-n deleted the fix_windows branch November 27, 2022 16:10
nat-n added a commit that referenced this pull request Nov 27, 2022
* Fix various issues manifesting on windows

- Make the tests that break on python37 on windows only run for python >= 3.8
- Reenable disabled test matrix item for windows-python37

In shell tasks:
- check for sh installed with git
- trust git bash over bash on the path which might be a decoy put there to trick us
- add test for the default powershell, as distinct from pwsh

* Revert "Revert "PoetryExecutor does not use poetry if POETRY_VIRTUALENVS_CREATE=false #65""

This reverts commit e6e162e.

* Always explicitly use the poetry virtualenv if possible in the poetry executor

This removes an optimization that probably does add much value anymore, but
does seem to cause tasks to be run without the correct virtual_env in some
scenarios on windows.

Also make process of updaating the path env var to enable a venv try to avoid
redundant updates in case the virtualenv is already active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant