Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If display bounds are out of sync with time conductor, don't purge data out of bounds #7732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented May 14, 2024

Closes #6460

Describe your changes:

In addition to panning and zooming, also check if we're paused to not purge data out of bounds.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@shefalijoshi shefalijoshi added this to the Target:4.0.1 milestone May 14, 2024
@shefalijoshi shefalijoshi requested a review from akhenry May 14, 2024 18:55
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.23%. Comparing base (810d580) to head (753d2a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7732      +/-   ##
==========================================
- Coverage   56.87%   56.23%   -0.65%     
==========================================
  Files         673      673              
  Lines       27182    27182              
  Branches     2635     2635              
==========================================
- Hits        15461    15285     -176     
- Misses      11390    11566     +176     
  Partials      331      331              
Flag Coverage Δ
e2e-full 23.56% <ø> (-18.06%) ⬇️
e2e-stable 59.75% <ø> (-0.72%) ⬇️
unit 49.25% <100.00%> (-0.02%) ⬇️
Files Coverage Δ
src/plugins/plot/MctPlot.vue 38.81% <100.00%> (ø)
src/plugins/timeConductor/TimePopupRealtime.vue 29.72% <ø> (ø)

... and 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810d580...753d2a9. Read the comment docs.

@akhenry
Copy link
Contributor

akhenry commented May 21, 2024

Tests, please. Nothing should be pushed any more without tests.

Create new test spec for plot controls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots should not purge data that's out of bounds if it is paused
3 participants