Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLA Needed] docs: fix typo in comment #7701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eltociear
Copy link
Contributor

Describe your changes:

minor fix

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.39%. Comparing base (a961d7e) to head (4b89e0c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7701      +/-   ##
==========================================
- Coverage   56.75%   56.39%   -0.37%     
==========================================
  Files         672      672              
  Lines       27182    27182              
  Branches     2635     2635              
==========================================
- Hits        15426    15328      -98     
- Misses      11426    11524      +98     
  Partials      330      330              
Flag Coverage Δ
e2e-full 23.55% <ø> (-18.30%) ⬇️
e2e-stable 59.97% <ø> (-0.06%) ⬇️
unit 49.17% <ø> (-0.06%) ⬇️

see 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a961d7e...4b89e0c. Read the comment docs.

@@ -127,7 +127,7 @@ export async function basicTagsTests(page) {
await page.getByRole('searchbox', { name: 'Search Input' }).click();
await page.getByRole('searchbox', { name: 'Search Input' }).fill('sc');

//Expect Science Tag to be present and and Driving Tags to be deleted
//Expect Science Tag to be present and Driving Tags to be deleted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between comment decl and the comment would be great

@ozyx
Copy link
Member

ozyx commented Apr 22, 2024

Thank you so much for your contribution! If you haven't already, please complete and submit a Contributor License Agreement (CLA). This is required before we can merge your code.

@ozyx ozyx added the source:community Community contribution or request label Apr 22, 2024
@ozyx ozyx changed the title Update plotTagsUtils.js [CLA Needed] docs: fix typo in comment Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants