Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Fix for ITC calendar being cutoff #7662

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rukmini-bose
Copy link
Contributor

Closes
#7661

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@rukmini-bose rukmini-bose marked this pull request as ready for review April 18, 2024 17:16
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.39%. Comparing base (5a06b51) to head (5f427bd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7662      +/-   ##
==========================================
- Coverage   56.68%   56.39%   -0.30%     
==========================================
  Files         672      672              
  Lines       27183    27183              
  Branches     2634     2634              
==========================================
- Hits        15409    15330      -79     
- Misses      11447    11525      +78     
- Partials      327      328       +1     
Flag Coverage Δ
e2e-full 23.55% <ø> (-17.98%) ⬇️
e2e-stable 60.01% <ø> (+0.06%) ⬆️
unit 49.20% <ø> (-0.03%) ⬇️

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a06b51...5f427bd. Read the comment docs.

Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We eventually need to put a task on our list to do mobile styling to the picker itself - but that's another issue. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Conductor calendar popup appears cut off
3 participants