Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow, alignment and padding in text and button elements #7541

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Mar 1, 2024

Closes #7540

Describe your changes:

  • Adds overflow: hidden to Condition Widget label and alphanumeric wrappers.
  • Adds a simple and common SCSS mixin for text views (Hyperlink links and layout text drawing objects) that normalizes overflow, padding and alignment.

Screenshot 2024-03-01 at 5 10 36 PM

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes Notable Change ? For example, will this break compatibility with existing APIs or projects which source these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

- Adds `overflow: hidden` to Condition Widget label and
alphanumeric wrappers.
@charlesh88 charlesh88 added the bug:regression It used to work. Now it doesn't :( label Mar 1, 2024
@charlesh88 charlesh88 added this to the Target:4.0.0 milestone Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.20%. Comparing base (5fc5c13) to head (a8896a3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7541      +/-   ##
==========================================
+ Coverage   56.16%   56.20%   +0.03%     
==========================================
  Files         672      672              
  Lines       27112    27112              
  Branches     2635     2635              
==========================================
+ Hits        15227    15237      +10     
+ Misses      11560    11550      -10     
  Partials      325      325              
Flag Coverage Δ
e2e-full 23.60% <ø> (ø)
e2e-stable 59.99% <ø> (+0.02%) ⬆️
unit 49.14% <ø> (+0.01%) ⬆️

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc5c13...a8896a3. Read the comment docs.

@charlesh88 charlesh88 changed the title Prevent scrollbars on Condition Widgets when small Fix overflow, alignment and padding in text and button elements Mar 2, 2024
@charlesh88 charlesh88 requested review from davetsay and ozyx March 2, 2024 01:54
- Adds `overflow: hidden` to Condition Widget label and
alphanumeric wrappers.
@unlikelyzero unlikelyzero added type:bug and removed bug:regression It used to work. Now it doesn't :( labels Mar 3, 2024
@unlikelyzero unlikelyzero self-requested a review March 3, 2024 15:50
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we add some minimal coverage. I think we could update the display layout visual test to add a condition widget

@charlesh88
Copy link
Contributor Author

@unlikelyzero How can I help move this through? Should I add tests? I'm not sure how to check against what we already have vs. the delta for new.

@unlikelyzero
Copy link
Collaborator

All css changes have been approved by @davetsay and @charlesh88

@ozyx ozyx requested a review from unlikelyzero March 13, 2024 17:44
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @charlesh88 .
One question. Have you tested this against Jasper's complex views? Not that it should block this PR but it may be good to see how this might affect those.

Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlesh88 I checked the latest percy diffs and didn't see anything that seemed related to these changes, so this could use a visual test. Let's sync on it and we can push this through

@unlikelyzero
Copy link
Collaborator

@ozyx , I met with @charlesh88 and we discussed a simple test with 4 objects within a display layout:
Hyperlink at minimum height (10px)
Hyperlink at minimum width (20px)
Layout Text at minimum height (10px)
Layout Text at minimum width (20px)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow, alignment and padding in text and button elements causing problems
5 participants