Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tree items more actionable and add AppAction for expanding the object tree #5997

Merged
merged 9 commits into from Jan 26, 2023
Merged

Make tree items more actionable and add AppAction for expanding the object tree #5997

merged 9 commits into from Jan 26, 2023

Commits on Jan 25, 2023

  1. style: add visibility to tree expand triangles 

    - The purpose of this is so that Playwright can perform actionability checks on the tree items. This will make operations involving expanding tree items much easier to perform in e2e.
    @ozyx
    ozyx committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    dda4b3f View commit details
    Browse the repository at this point in the history

  2. feat(e2e): Add AppAction to expand the entire tree

    @ozyx
    ozyx committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    b37a021 View commit details
    Browse the repository at this point in the history

  3. fix: wait for loading indicator

    @ozyx
    ozyx committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a175d3a View commit details
    Browse the repository at this point in the history

  4. test: add test for expandEntireTree

    @ozyx
    ozyx committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f00024a View commit details
    Browse the repository at this point in the history

  5. test: update expandEntireTree and tree selectors 

    - Use dynamic aria-label for different tree implementations

- Get rid of CSS ids which are only for testing

- Update percy tree scope selector
    @ozyx
    ozyx committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ed68c56 View commit details
    Browse the repository at this point in the history

  6. chore(lint): remove unused variable

    @ozyx
    ozyx committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4972d8e View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Merge branch 'master' into mct5994

    @unlikelyzero
    unlikelyzero committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b2b2276 View commit details
    Browse the repository at this point in the history

  2. refactor(e2e): update tree locators

    @ozyx
    ozyx committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    003b306 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mct5994

    @ozyx
    ozyx committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    3b7a41c View commit details
    Browse the repository at this point in the history