4417 fix codeql issues

[michaelrogers]

Closes #4417

Describe your changes:

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes?
• Command line build passes?
• Has this been smoke tested?
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Changes appear not to be breaking changes?
• Appropriate unit tests included?
• Code style and in-line documentation are appropriate?
• Commit messages meet standards?
• Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
• Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

[codecov]

Codecov Report

Merging #5793 (ed9c4a4) into master (866859a) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ed9c4a4 differs from pull request most recent head b7f1ada. Consider uploading reports for the commit b7f1ada to get more accurate results

@@            Coverage Diff             @@
##           master    #5793      +/-   ##
==========================================
- Coverage   54.12%   54.09%   -0.03%     
==========================================
  Files         598      598              
  Lines       22945    22945              
  Branches     2076     2076              
==========================================
- Hits        12418    12413       -5     
- Misses       9945     9950       +5     
  Partials      582      582              

Flag	Coverage Δ		*Carryforward flag
e2e-ci	39.49% <ø> (ø)		Carriedforward from 212a78b
e2e-full	51.23% <ø> (ø)		Carriedforward from 212a78b
e2e-stable	48.73% <ø> (-0.01%)	⬇️
unit	50.30% <ø> (-0.04%)	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...c/plugins/persistence/couch/CouchObjectProvider.js	50.43% <0.00%> (-1.08%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866859a...b7f1ada. Read the comment docs.

[unlikelyzero]

These changes look great!

Can you update our relevant documentation with why these matter?

Also, can you create a calendar event/ticket to remove LGTM in december 2022? It looks like it's shutting down

[unlikelyzero]

@michaelrogers it looks like app.js will be removed sooner than I thought. We should wait until #5797 is merged and then updated accordingly

[akhenry]

app.js has been removed. Can we move ahead with this?

[unlikelyzero]

This looks great. We just need to ignore **/*.spec.js changes, and this is gtg