Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moment #5509

Merged
merged 2 commits into from Jul 14, 2022
Merged

Update moment #5509

merged 2 commits into from Jul 14, 2022

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Jul 14, 2022

Describe your changes:

Quick fix for moment security issue moment/moment#6015 (comment)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #5509 (eedc523) into master (eedc523) will not change coverage.
The diff coverage is n/a.

❗ Current head eedc523 differs from pull request most recent head 16bbc3f. Consider uploading reports for the commit 16bbc3f to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5509   +/-   ##
=======================================
  Coverage   53.38%   53.38%           
=======================================
  Files         594      594           
  Lines       22684    22684           
  Branches     2049     2049           
=======================================
  Hits        12110    12110           
  Misses       9997     9997           
  Partials      577      577           
Flag Coverage Δ *Carryforward flag
e2e-ci 37.56% <0.00%> (ø)
e2e-full 46.91% <0.00%> (ø) Carriedforward from db97acb
unit 50.07% <0.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedc523...16bbc3f. Read the comment docs.

@ozyx ozyx self-requested a review July 14, 2022 22:21
@ozyx ozyx enabled auto-merge (squash) July 14, 2022 22:24
@ozyx ozyx merged commit 0062191 into master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants