Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUMULUS-3027 -- Tightly constrain typescript version due to knex typing #3095

Merged
merged 4 commits into from
Aug 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -40,6 +40,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

### Changed

- **CUMULUS-3027**
- Pinned typescript to ~4.7.x to address typing incompatibility issues
discussed in https://github.com/knex/knex/pull/5279
- Update generate-ts-build-cache script to always install root project dependencies
- **CUMULUS-2940**
- Updated bulk operation lambda to utilize system wide rds_connection_timing
configuration parameters from the main `cumulus` module
Expand Down
3 changes: 2 additions & 1 deletion bamboo/generate-ts-build-cache.sh
Expand Up @@ -27,9 +27,10 @@ if [[ $USE_CACHED_BOOTSTRAP == true ]]; then
git checkout "$GIT_SHA"
else
CURRENT_WORKING_DIR=$(pwd)
npm install
fi

npm install

# Bootstrap to install/link packages
npm run ci:bootstrap-no-scripts

Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -152,7 +152,7 @@
"supertest": "^4.0.2",
"tough-cookie": "~4.0.0",
"tsc-watch": "^4.2.8",
"typescript": "^4.4.3",
"typescript": "~4.7.3",
"uuid": "^8.2.0",
"webpack": "^5.58.1",
"webpack-cli": "^4.9.0",
Expand Down