Skip to content

Commit

Permalink
CUMULUS-3027 -- Tightly constrain typescript version due to knex typi…
Browse files Browse the repository at this point in the history
…ng (#3095)

* Tightly constrain typescript verseion due to knex typing

Unpinned dependency resulted in typescript 4.8 being installed,
however knex (all versions) has an outstanding bug:
knex/knex#5279

* Add CHANGELOG 🔔

* Update generate-ts-build-cache to always 'npm install'

* Update CHANGELOG
  • Loading branch information
Jkovarik committed Aug 31, 2022
1 parent d3e5d54 commit e7d21c9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -40,6 +40,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

### Changed

- **CUMULUS-3027**
- Pinned typescript to ~4.7.x to address typing incompatibility issues
discussed in https://github.com/knex/knex/pull/5279
- Update generate-ts-build-cache script to always install root project dependencies
- **CUMULUS-2940**
- Updated bulk operation lambda to utilize system wide rds_connection_timing
configuration parameters from the main `cumulus` module
Expand Down
3 changes: 2 additions & 1 deletion bamboo/generate-ts-build-cache.sh
Expand Up @@ -27,9 +27,10 @@ if [[ $USE_CACHED_BOOTSTRAP == true ]]; then
git checkout "$GIT_SHA"
else
CURRENT_WORKING_DIR=$(pwd)
npm install
fi

npm install

# Bootstrap to install/link packages
npm run ci:bootstrap-no-scripts

Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -152,7 +152,7 @@
"supertest": "^4.0.2",
"tough-cookie": "~4.0.0",
"tsc-watch": "^4.2.8",
"typescript": "^4.4.3",
"typescript": "~4.7.3",
"uuid": "^8.2.0",
"webpack": "^5.58.1",
"webpack-cli": "^4.9.0",
Expand Down

0 comments on commit e7d21c9

Please sign in to comment.