Better types for addJob

[nathanbabcock]

Closes #718.

[nathanbabcock]

@Balearica I saw you active in a few of the other Typescript PRs 😉 Any thoughts on this one?

Are there any additional job type signatures I'm missing, aside from recognize, detect, and setParameters?

This change should be non-breaking (since it only affects types) and 100% backwards compatible with the existing type definitions. I've been using it manually in my projects for a few weeks now.

[Balearica]

@nathanbabcock Thank you for your contribution. I am not familiar with the nuances of Typescript/Intellisense but given your description this change seems helpful. I am suggesting one minor edit.

Are there any additional job type signatures I'm missing, aside from recognize, detect, and setParameters?

While technically scheduler.addJob can be used to call any method a worker contains, the only functions that should be used through scheduler.addJob are detect and recognize. This is because scheduler.addJob assumes all workers are homogenous and assigns jobs to an arbitrary worker. Using setParameters this way does not make sense because you would be changing the settings for a single worker (essentially) at random. Therefore, to avoid any confusion can you remove the line for setParameters? (I realize that ConfigResult was a return type before your edits, but this seems as good a time as ever to fix.)

[nathanbabcock]

@Balearica thanks for the thoughtful reply. Your reasoning makes perfect sense.

I've removed setParameters from addJob, leaving detect and recognize as the two supported job types.