chore(napi): allow value attribute on enum variants #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to customize the enum value for string_enum. So far, only the case attribute was allowing us to customize the value of those variants, this is a next step in allowing the value to be different from the actual name. This has a new test, and snapshots have been updated accordingly.
Brooooooklyn
approved these changes
May 17, 2024
sure |
southorange0929
pushed a commit
to southorange0929/napi-rs
that referenced
this pull request
May 17, 2024
This allows us to customize the enum value for string_enum. So far, only the case attribute was allowing us to customize the value of those variants, this is a next step in allowing the value to be different from the actual name. This has a new test, and snapshots have been updated accordingly. @Brooooooklyn - could we include that in napi v2 and tag after it?
Brooooooklyn
pushed a commit
that referenced
this pull request
May 18, 2024
This allows us to customize the enum value for string_enum. So far, only the case attribute was allowing us to customize the value of those variants, this is a next step in allowing the value to be different from the actual name. This has a new test, and snapshots have been updated accordingly. @Brooooooklyn - could we include that in napi v2 and tag after it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to customize the enum value for string_enum. So far, only the case attribute was allowing us to customize the value of those variants, this is a next step in allowing the value to be different from the actual name.
This has a new test, and snapshots have been updated accordingly.
@Brooooooklyn - could we include that in napi v2 and tag after it?