Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(napi): Function build_thfn support calledhandled mode #2114

Merged
merged 3 commits into from
May 18, 2024

Conversation

southorange0929
Copy link
Contributor

No description provided.

@Brooooooklyn
Copy link
Sponsor Member

You should make the typegen correct for the calledhandled = true tsfn

@southorange0929
Copy link
Contributor Author

I think we don't need to add some logic for ThreadsafeFunctionBuilder with calleehandled = true.
It just is used to generate ThreadsafeFunction which is support typegen, right?

Brooooooklyn
Brooooooklyn previously approved these changes May 17, 2024
@southorange0929
Copy link
Contributor Author

Resolve conflict

@Brooooooklyn Brooooooklyn merged commit c52d204 into napi-rs:main May 18, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants