-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nw.js support #2053
base: main
Are you sure you want to change the base?
nw.js support #2053
Conversation
Checks if a node library function is available in the executable, if not, it loads the external library version of node via node.dll.
The failing workflow (macOS arm64) does not seem related to the change. Anyone else have thoughts on this? |
Looks like I need to do: cargo fmt, doing that now. |
this conflicts with this PR #2026, since we use the exact same patch fix, I have not added any modification to the MSVC version, but I use a very similar fix for mingw support. I can also do this change if @Brooooooklyn decides too, remember, that under mingw version we use |
If same functionality for nw.js support on windows are implemented in PR #2026 , I'm ok with that one being accepted and will close this one after that. |
not really, I made sure to single out MSVC, (since I can't test on MSVC), can you provide a test case for nw.js |
Ah, I see, I'll take a look at your tests and take a look at doing a PR to your fork to allow it to support MSVC and windows nw.js testing. Or if your PR gets accepted before that, I'll just back to doing a PR vs main. |
This is to allow for node files to also work with Windows nw.js. not just electron and node.
Using the patch from this issue: #1480.
The patch checks if a node library function is available in the executable, if not, it loads the external library version of node via node.dll (which is already loaded.)
(added verification)