Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete reference #1414

Merged
merged 2 commits into from Dec 29, 2022
Merged

Delete reference #1414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2a492a
fix(napi): require higher version of once_cell
Brooooooklyn Dec 29, 2022
877d631
fix(napi): only delete reference in custom gc
Brooooooklyn Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/napi/Cargo.toml
View file
Open in desktop
Expand Up @@ -50,7 +50,7 @@ tokio_time = ["tokio/time"]

[dependencies]
ctor = "0.1"
once_cell = "1"
once_cell = "1.16"
thread_local = "1"
bitflags = "1"

Expand Down
6 changes: 0 additions & 6 deletions crates/napi/src/bindgen_runtime/module_register.rs
View file
Open in desktop
Expand Up @@ -598,12 +598,6 @@ extern "C" fn custom_gc(
_context: *mut std::ffi::c_void,
data: *mut std::ffi::c_void,
) {
let mut ref_count = 0;
check_status_or_throw!(
env,
unsafe { sys::napi_reference_unref(env, data as sys::napi_ref, &mut ref_count) },
"Failed to unref Buffer reference in Custom GC"
);
check_status_or_throw!(
env,
unsafe { sys::napi_delete_reference(env, data as sys::napi_ref) },
Expand Down