fix(napi): napi_create_async_work incorrect argument (napi-rs#1392) #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpilch
force-pushed
the
async_work_napi_value_arg
branch
from
7159873
to
3b85d55
Compare
The third argument to `napi_create_async_work` (async_resource_name) should be a `napi_value` that corresponds to a null-terminated utf-8 string. This resolves errors running Next.js with GraalVM. oracle/graal#5582 oracle/graal#5581
patrickpilch
force-pushed
the
async_work_napi_value_arg
branch
from
3b85d55
to
fd8de90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third argument to
napi_create_async_work(async_resource_name) should be anapi_valuethat corresponds to a null-terminated utf-8 string.This resolves errors running Next.js with GraalVM.
oracle/graal#5582
oracle/graal#5581