Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "run_script" for "Env" #1393

Merged
merged 3 commits into from Dec 16, 2022
Merged

add "run_script" for "Env" #1393

merged 3 commits into from Dec 16, 2022

Conversation

F001
Copy link
Contributor

@F001 F001 commented Dec 15, 2022

Fix #1380

F001 and others added 2 commits December 16, 2022 12:16
@F001 @Brooooooklyn
Apply suggestions from code review
c275aed 
use `AsRef<str>` instead of `&str`

Co-authored-by: LongYinan <lynweklm@gmail.com>
@F001
use AsRef<str> instead of &str
ce57e5a
Brooooooklyn
Brooooooklyn approved these changes Dec 16, 2022
View reviewed changes
Copy link
Sponsor Member

@Brooooooklyn Brooooooklyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Brooooooklyn Brooooooklyn merged commit d253135 into napi-rs:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

napi_run_script is not exported in Env type
2 participants
@F001 @Brooooooklyn