Bug fix: typed arrays ref shouldn't use offset. #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice from the n-api docs that the data returned from `napi_get_typedarray_info` is already adjusted by the byte offset. https://nodejs.org/api/n-api.html#napi_get_typedarray_info This means that when `as_ref`/`as_mut` apply the byte offset, the offset is in practice applied twice. This wasn't caught in tests because no test tried to modify a typed array with a byte offset, and the test didn't us the typed array structs, only `JsTypedArray`. If you want, I can modify the rest of the functions in examples/napi-compt-mode/src/arraybuffers.rs and the matching tests, to test all typed arrays. IMO the `byte_offset` field can be removed entirely from the struct, but I wanted to submit a minimal PR.
|
@Brooooooklyn, can you please release a version with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice from the n-api docs that the data returned from
napi_get_typedarray_infois already adjusted by the byte offset. https://nodejs.org/api/n-api.html#napi_get_typedarray_infoThis means that when
as_ref/as_mutapply the byte offset, the offset is in practice applied twice.This wasn't caught in tests because no test tried to modify a typed array with a byte offset, and the test didn't us the typed array structs, only
JsTypedArray. If you want, I can modify the rest of the functions in examples/napi-compt-mode/src/arraybuffers.rs and the matching tests, to test all typed arrays.IMO the
byte_offsetfield can be removed entirely from the struct, but I wanted to submit a minimal PR.