Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(napi): BigInt::get_u64 lossless check #1348

Merged
merged 1 commit into from Oct 22, 2022
Merged

fix(napi): BigInt::get_u64 lossless check #1348

merged 1 commit into from Oct 22, 2022

Conversation

Wodann
Copy link
Contributor

@Wodann Wodann commented Oct 21, 2022

Fixes #1347.

@Wodann Wodann mentioned this pull request Oct 21, 2022
Merged
6 tasks
@Brooooooklyn Brooooooklyn changed the title fix: BigInt::get_64 lossless check fix(napi): BigInt::get_u64 lossless check Oct 22, 2022
Brooooooklyn
Brooooooklyn approved these changes Oct 22, 2022
View reviewed changes
Copy link
Sponsor Member

@Brooooooklyn Brooooooklyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Brooooooklyn Brooooooklyn merged commit 77060ad into napi-rs:main Oct 22, 2022
@Wodann Wodann deleted the fix/get-u64-lossless branch October 22, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigInt::get_u64 does not correctly return losslessness
2 participants
@Wodann @Brooooooklyn