Fixes #1338 use after free with async, and fixes #1340 #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaeroxe
force-pushed
the
fix-async-use-after-free
branch
4 times, most recently
from
b15e902
to
bc8bac4
Compare
Xaeroxe
force-pushed
the
fix-async-use-after-free
branch
4 times, most recently
from
7b33813
to
28b6d93
Compare
|
@Brooooooklyn this is ready for review |
|
I added a commit to this PR which implements my first solution for #1340 |
Xaeroxe
changed the title
|
@Xaeroxe thanks! I'll add some tests before I merge this |
Brooooooklyn
force-pushed
the
fix-async-use-after-free
branch
from
8f072e4
to
06b3171
Compare
|
@Xaeroxe I decide to allow mut ref with |
|
Sure, that seems good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1338
EDIT: Now also fixes #1340