-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows gnu target #2026
base: main
Are you sure you want to change the base?
Add windows gnu target #2026
Conversation
and the dependencies might have to be updated as well, because this is self hosting
|
Ah, I see the failing tests, Ill work on that |
65b5336
to
eede4d6
Compare
I understand, msvc is not a configuration but target_env="msvc" is. To test this under windows-gnu you need the gnu version of node, tell me if this is required |
@Kreijstal can you add a Windows gnu CI to test the platform? |
this adds clang64 compiler to the test suite
I added test that tell you that it compiles at least with rust, in the msys2 platform however the tests will fail since they can't install rollup, for the reason that this pull request is precisely trying to fix. |
Good day,
I am not well acquainted with this project or rust or node api, but there has been this bug that has been bugging me for a while, when using napi-rs, I put msvc target on its own category, since it is different from clang or gcc, and added static linking for windows, I added a build.rs script for napi, so that you can
cargo test
on the repository. Additionally I added dynamical symbol loading for gnu targets as well, so you can either choose to static or dynamic load, since I do not have msvc, I can not test how this works for msvc, but since I did not change its path, it should work as it has worked before. I noticed some people have the same issue and someone even came with a patch!/Workaround!Fixes #2001
Fixes #1893
related #1480 (comment) (patch came from this thread)
Please review