Skip to content

Commit

Permalink
fix(cli): set cmake toolchain for android cross build
Browse files Browse the repository at this point in the history
  • Loading branch information
Brooooooklyn committed Dec 15, 2022
1 parent 5e9a9ff commit dfea617
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cli/src/build.ts
Expand Up @@ -429,6 +429,8 @@ export class BuildCommand extends Command {
CC: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/${targetArch}-linux-${targetPlatform}-clang`,
CXX: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/${targetArch}-linux-${targetPlatform}-clang++`,
AR: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar`,
CMAKE_TOOLCHAIN_FILE_armv7_linux_androideabi: `${ANDROID_NDK_LATEST_HOME}/build/cmake/android.toolchain.cmake`,
CMAKE_TOOLCHAIN_FILE_aarch64_linux_android: `${ANDROID_NDK_LATEST_HOME}/build/cmake/android.toolchain.cmake`,
PATH: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin:${process.env.PATH}`,
})
}
Expand Down

1 comment on commit dfea617

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dfea617 Previous: 5e9a9ff Ratio
noop#napi-rs 58422376 ops/sec (±1.52%) 68019326 ops/sec (±0.22%) 1.16
noop#JavaScript 733805064 ops/sec (±1.06%) 592840594 ops/sec (±0.11%) 0.81
Plus number#napi-rs 18149236 ops/sec (±1.27%) 21970040 ops/sec (±0.16%) 1.21
Plus number#JavaScript 719783322 ops/sec (±1.14%) 592259835 ops/sec (±0.11%) 0.82
Create buffer#napi-rs 385147 ops/sec (±9.2%) 447611 ops/sec (±6.99%) 1.16
Create buffer#JavaScript 1939556 ops/sec (±5.79%) 2103121 ops/sec (±5.25%) 1.08
createArray#createArrayJson 38254 ops/sec (±1.24%) 45263 ops/sec (±0.13%) 1.18
createArray#create array for loop 6717 ops/sec (±1.15%) 8426 ops/sec (±0.13%) 1.25
createArray#create array with serde trait 6810 ops/sec (±1.01%) 8230 ops/sec (±0.3%) 1.21
getArrayFromJs#get array from json string 16733 ops/sec (±0.96%) 18659 ops/sec (±0.09%) 1.12
getArrayFromJs#get array from serde 9270 ops/sec (±0.66%) 10692 ops/sec (±0.06%) 1.15
getArrayFromJs#get array with for loop 11436 ops/sec (±0.97%) 12874 ops/sec (±0.77%) 1.13
Get Set property#Get Set from native#u32 410847 ops/sec (±5.99%) 413138 ops/sec (±4.49%) 1.01
Get Set property#Get Set from JavaScript#u32 327326 ops/sec (±6.4%) 337955 ops/sec (±4.28%) 1.03
Get Set property#Get Set from native#string 361444 ops/sec (±5.95%) 376338 ops/sec (±4.21%) 1.04
Get Set property#Get Set from JavaScript#string 311841 ops/sec (±6.03%) 328275 ops/sec (±4.37%) 1.05
Async task#spawn task 34732 ops/sec (±3.36%) 36015 ops/sec (±1.22%) 1.04
Async task#ThreadSafeFunction 1872 ops/sec (±5.64%) 2005 ops/sec (±4.54%) 1.07
Async task#Tokio future to Promise 30365 ops/sec (±4.24%) 31729 ops/sec (±2.76%) 1.04
Query#query * 100 1691 ops/sec (±6.47%) 1981 ops/sec (±5.31%) 1.17
Query#query * 1 25932 ops/sec (±6.34%) 31952 ops/sec (±0.58%) 1.23

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.