Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permisions to deploy steep #338

Merged
merged 1 commit into from Jan 24, 2024
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jan 24, 2024

This pr fixes the bug of 403 error during create github release:

Run softprops/action-gh-release@v1
πŸ‘©β€πŸ­ Creating new GitHub release for tag v0.7.4...
⚠️ GitHub release failed with status: 403
undefined
retrying... (2 retries remaining)
πŸ‘©β€πŸ­ Creating new GitHub release for tag v0.7.4...
⚠️ GitHub release failed with status: 403
undefined
retrying... (1 retries remaining)
πŸ‘©β€πŸ­ Creating new GitHub release for tag v0.7.4...
⚠️ GitHub release failed with status: 403
undefined
retrying... (0 retries remaining)
❌ Too many retries. Aborting...
Error: Too many retries.

softprops/action-gh-release#400 (comment)

I have added also id-token: write because this is set of permissions that we have in the main repository.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (aa84627) 100.00% compared to head (e47c217) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #338   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2750      2750           
=========================================
  Hits          2750      2750           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks @Czaki

@DragaDoncila DragaDoncila merged commit 595b088 into napari:main Jan 24, 2024
32 checks passed
@Czaki Czaki deleted the fix_release branch January 24, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants