Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Window menu to app-model #6905

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

lucyleeow
Copy link
Contributor

@lucyleeow lucyleeow commented May 9, 2024

References and relevant issues

Follow on from #4977, new PR to avoid bad merging due to conflicts.

Changed file test_viewer_toggler.py filename to test_togglers.py and added a test for the new DockWidgetToggleAction

Description

Migrate window menu to app-model

@github-actions github-actions bot added tests Something related to our tests qt Relates to qt labels May 9, 2024
@lucyleeow lucyleeow mentioned this pull request May 9, 2024
12 tasks
@lucyleeow lucyleeow added this to the 0.5.0 milestone May 9, 2024
@lucyleeow
Copy link
Contributor Author

cc @DragaDoncila

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.44%. Comparing base (a9c25e6) to head (844bcfc).
Report is 1 commits behind head on main.

Files Patch % Lines
napari/_qt/qt_main_window.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6905      +/-   ##
==========================================
- Coverage   92.45%   92.44%   -0.02%     
==========================================
  Files         614      614              
  Lines       55166    55192      +26     
==========================================
+ Hits        51002    51020      +18     
- Misses       4164     4172       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qt Relates to qt tests Something related to our tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant