Add deprecation message to CallDefault function partly resolves issue#6257

[MarchisLost]

References and relevant issues

Partly closes #6257 by adding a deprecation message to the CallDefault function that seems to not be used since #2266

Description

• - My PR is the minimum possible work for the desired functionality
• - I have commented my code, particularly in hard-to-understand areas
• - I have made corresponding changes to docstrings and documentation (open a PR on the docs repository (https://github.com/napari/docs) if relevant!)
• - I have added tests that prove my fix is effective or that my feature works
• - If I included new strings, I have used trans._("some string") to make them localizable.
  (For more information see our translations guide).

[melissawm]

Hi @MarchisLost - thanks for your contribution!

Would you mind changing the title of your PR to be more descriptive of the problem you are solving? This will help your PR get more visibility and will help the maintainers understand your work better. In your case, I would suggest something like "Add deprecation message to CallDefault function" or something similar.

Welcome and let us know if you have questions 😄

[MarchisLost]

Hi, thank you for the feedback.
I have changed the PR title.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (4a56237) to head (808c1ed).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6901      +/-   ##
==========================================
- Coverage   92.48%   92.43%   -0.06%     
==========================================
  Files         614      614              
  Lines       55181    55182       +1     
==========================================
- Hits        51035    51008      -27     
- Misses       4146     4174      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DragaDoncila]

Hi @MarchisLost thanks for the PR! I'm pinging @melonora for review, because I think this is similar to #6836 that he recently looked at

[melonora]

Suggested change

	warnings.warn(
	trans._(
	'`CallDefault` is deprecated since 0.4.6 and will be removed in the future',
	),
	category=DeprecationWarning,
	)
	warnings.warn(
	trans._(
	'`CallDefault` is deprecated in napari v0.5.0 and will be removed in v0.6.0.',
	),
	category=DeprecationWarning,
	)

[melonora]

Thanks @MarchisLost (interesting name haha) and welcome to napari! I have checked and indeed this does not seem to be used at all. However, for good practice we have 1 release always for warning that it is deprecated and then the release after that we remove. If we slightly change the message we are good to go for merging this one. Once you have accepted the suggestion I will mark your PR ready for merge and then if nobody else has obligations we merge within a day.

[melonora]

Approved! Thanks:)

[MarchisLost]

Hi @melonora thank you!

[melonora]

in it goes!