-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale bar #6892
Draft
melonora
wants to merge
14
commits into
napari:main
Choose a base branch
from
melonora:scale_bar
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Scale bar #6892
+112
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
github-actions
bot
added
qt
Relates to qt
preferences
Issues relating to the creation of new preference fields/panels
labels
May 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6892 +/- ##
==========================================
+ Coverage 92.35% 92.42% +0.07%
==========================================
Files 605 614 +9
Lines 54491 55195 +704
==========================================
+ Hits 50325 51014 +689
- Misses 4166 4181 +15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
depends on #6730
closes #6758
Description
This PR is another step in napari to go towards easily creating publication ready figures. The main problem with the current implementation of the scale bar is that it does not respond to canvas size. This means that if you were to do `viewer.screenshot(scale=8) the scale bar will show very small. This PR makes it so that the length of the scale bar responds to the horizontal canvas size and the width of the line segment and the font size responds to the vertical canvas size. Currently some of the settings have been made available in the experimental settings menu. This is not definitive, because @Olusesan and I would like a discussion first on the api / settings that should be made available to the user along with discussions of the scale bar interface in general.
We did remove the whiskers for now of the scale bar so the scale bar becomes more like the scale bar in Fiji. Main reason for that was because the height of the whiskers is another parameter, where the scale bar already has a few parameters.
This PR was also so far done in paired coding sessions with @Olusesan.