Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale bar #6892

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Scale bar #6892

wants to merge 14 commits into from

Conversation

melonora
Copy link
Contributor

@melonora melonora commented May 6, 2024

References and relevant issues

depends on #6730
closes #6758

Description

This PR is another step in napari to go towards easily creating publication ready figures. The main problem with the current implementation of the scale bar is that it does not respond to canvas size. This means that if you were to do `viewer.screenshot(scale=8) the scale bar will show very small. This PR makes it so that the length of the scale bar responds to the horizontal canvas size and the width of the line segment and the font size responds to the vertical canvas size. Currently some of the settings have been made available in the experimental settings menu. This is not definitive, because @Olusesan and I would like a discussion first on the api / settings that should be made available to the user along with discussions of the scale bar interface in general.

We did remove the whiskers for now of the scale bar so the scale bar becomes more like the scale bar in Fiji. Main reason for that was because the height of the whiskers is another parameter, where the scale bar already has a few parameters.

This PR was also so far done in paired coding sessions with @Olusesan.

melonora and others added 12 commits March 8, 2024 09:44
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
Co-authored-by: olusesan.ajina@gmail.com
@github-actions github-actions bot added qt Relates to qt preferences Issues relating to the creation of new preference fields/panels labels May 6, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.42%. Comparing base (35f5b12) to head (3fd75a5).
Report is 98 commits behind head on main.

Files Patch % Lines
napari/_qt/qt_main_window.py 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6892      +/-   ##
==========================================
+ Coverage   92.35%   92.42%   +0.07%     
==========================================
  Files         605      614       +9     
  Lines       54491    55195     +704     
==========================================
+ Hits        50325    51014     +689     
- Misses       4166     4181      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences Issues relating to the creation of new preference fields/panels qt Relates to qt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale bar does not respond to canvas size changes
1 participant