-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Warn if float image data being saved to non-tiff #6884
Open
psobolewskiPhD
wants to merge
12
commits into
napari:main
Choose a base branch
from
psobolewskiPhD:warn_on_float
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6884 +/- ##
==========================================
- Coverage 92.58% 92.53% -0.05%
==========================================
Files 612 612
Lines 55292 55315 +23
==========================================
- Hits 51193 51187 -6
- Misses 4099 4128 +29 ☔ View full report in Codecov by Sentry. |
Did you validate all extensions? |
Czaki
reviewed
May 2, 2024
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
for more information, see https://pre-commit.ci
Czaki
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
PR with bugfix
ready to merge
Last chance for comments! Will be merged in ~24h
tests
Something related to our tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Closes: #6670
Description
Only a subset of file types (e.g. TIFF) support float data, so if the user passes a different extension and dtype is float, then don't try saving to invalid format and instead warn the user.
Also added a test for this condition.
Also if no extension is provided and image is 3d or float, then use .tiff instead of png.
While there are skimage and imageio functions to convert arrays to int, they make assumptions, so I think this is the best way to handle this, rather than magic'ing a conversion.