Add typing to Layer.__init__ #6796
Open
+40
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6796 +/- ##
==========================================
+ Coverage 92.41% 92.43% +0.02%
==========================================
Files 615 614 -1
Lines 54892 55170 +278
==========================================
+ Hits 50729 50998 +269
- Misses 4163 4172 +9 ☔ View full report in Codecov by Sentry. |
Czaki
reviewed
Apr 6, 2024
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki
reviewed
Apr 9, 2024
| @@ -306,25 +307,29 @@ class Layer(KeymapProvider, MousemapProvider, ABC, metaclass=PostInit): | |||
|
|
|||
| def __init__( | |||
| self, | |||
| data, | |||
| ndim, | |||
| data: Union[npt.NDArray, list[npt.NDArray]], | |||
There was a problem hiding this comment.
It could be also dask, zarr, tensorstore.
| translate=None, | ||
| visible=True, | ||
| ): | ||
| affine: Optional[Union[npt.NDArray, Affine]] = None, |
There was a problem hiding this comment.
Suggested change
| affine: Optional[Union[npt.NDArray, Affine]] = None, | |
| affine: Union[npt.NDArray, Affine, None] = None, |
Comment on lines
+316
to
+318
| experimental_clipping_planes: Optional[ | ||
| Union[list[dict], list[ClippingPlane], ClippingPlaneList] | ||
| ] = None, |
There was a problem hiding this comment.
Suggested change
| experimental_clipping_planes: Optional[ | |
| Union[list[dict], list[ClippingPlane], ClippingPlaneList] | |
| ] = None, | |
| experimental_clipping_planes: Union[list[dict], list[ClippingPlane], ClippingPlaneList, None] = None, |
| rotate: Optional[ | ||
| Union[float, tuple[float, float, float], npt.NDArray] | ||
| ] = None, | ||
| scale: Optional[tuple[float, ...]] = None, |
There was a problem hiding this comment.
Suggested change
| scale: Optional[tuple[float, ...]] = None, | |
| scale: Optional[Sequence[float, ...]] = None, |
| ] = None, | ||
| scale: Optional[tuple[float, ...]] = None, | ||
| shear: Optional[npt.NDArray] = None, | ||
| translate: Optional[tuple[float, ...]] = None, |
There was a problem hiding this comment.
Suggested change
| translate: Optional[tuple[float, ...]] = None, | |
| translate: Optional[Sequence[float, ...]] = None, |
| @@ -596,7 +596,7 @@ def compute_multiscale_level_and_corners( | |||
|
|
|||
|
|
|||
| def coerce_affine( | |||
| affine: Union[npt.ArrayLike, Affine], | |||
| affine: Optional[Union[npt.ArrayLike, Affine]], | |||
There was a problem hiding this comment.
Suggested change
| affine: Optional[Union[npt.ArrayLike, Affine]], | |
| affine: Union[npt.ArrayLike, Affine, None], |
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
|
The mypy CI check is currently failing due to the new Two options to fix this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more typing - there were also a couple of code fixes I had to make after adding the typing.