-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Layer controls designs implementation and code refactor #6219
base: main
Are you sure you want to change the base?
Conversation
…lass to prevent other layer types failing tests
992546e
to
433955d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6219 +/- ##
==========================================
- Coverage 92.48% 92.40% -0.09%
==========================================
Files 614 621 +7
Lines 55181 55460 +279
==========================================
+ Hits 51036 51248 +212
- Misses 4145 4212 +67 ☔ View full report in Codecov by Sentry. |
94c3459
to
65daeb7
Compare
for more information, see https://pre-commit.ci
Hey @dalthviz, Are you looking for feedback on the code or on the functionality? We played around with this during the PR party and identified the following issues with the functionality:
But maybe you are looking for code and not functional suggestions, in which case, hold please. 😅 🙏 |
…buttons spacing and arrangement to be closer with the current/original layout
…nto layer_controls
Hi @jni ! Thank you for the feeback! Although a more code related review could be awesome (to see if the refactor approach I took makes sense), any feedback is appreciated! Checking the funtionality related feedback, maybe people would prefer things to look/work something like the following then?: Pushed a commit with some changes in case someone wants to check things locally :) Also, what do you think @isabela-pf ? |
Yes, that looks great! I'll try to make some time this coming week for some code review. Thank you! |
@dalthviz This works for me. Thank you for making the update! Thank you for the tag as well. Glad to see this getting some review! |
…nto layer_controls
References and relevant issues
Part of #5358
Description
Initial implementation of the designs being discussed at #5358 while taking into account possible future features that could affect the way the layer controls work/are instantiated (multi-layer selection and
LayerGroup
definition).The current changes only cover the controls for the Shapes layer type. From the GUI you can see something like:
Some of the elements that this PR changes:
QtWidgetControlsBase
,QtOpacityBlendingControls
,QtEdgeColorControl
,QtEdgeWidthSliderControl
, etc) that handle the layer attributes <-> widget values connections._add_radio_button_mode
,_add_push_button_action
,add_annotation_widget_controls
andadd_display_widget_controls
) in the baseQtLayerControls
class.QtLayerControls
class.Notes
⚠️ As mentioned, the current changes on the branch only make sure that the Shapes layer controls work so trying to use napari to create other layer types running from this branch will probably end up showing errors/failing to create the respective layer controls.To prevent errors/failing tests the old base layer controls class is still there for the controls of layer types still not changed. After moving all the control layer classes to use the new base definition it should be removed.