Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the docs downloading screenshots to LFS #4990

Merged
merged 3 commits into from Aug 31, 2022
Merged

Conversation

DragaDoncila
Copy link
Contributor

Description

@jni this PR adds the three recently committed pngs to LFS. It doesn't rewrite history (obviously), but it at least changes them to pointers from now on.

I think I did it right? I just added them to git lfs and then made sure they were listed in git lfs ls-files 🤷‍♀️

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@jni
Copy link
Member

jni commented Aug 28, 2022

Hmmm something seems to be wrong — it should also say "LFS file not shown" in the diff. But I would not be shocked at all to find that GH doesn't render a normal->LFS move correctly. Will check this out locally later today to make sure it works properly for me.

@Carreau
Copy link
Contributor

Carreau commented Aug 29, 2022

That seem correct to me:

$ cat <(find . -name '*.png'|sed 's/\.\///g') | grep -v -f <(git lfs ls-files -n | grep '.png'|sort )
napari/resources/logo.png

Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, checked this out and it works...

Why is the CI broken though?

@jni
Copy link
Member

jni commented Aug 31, 2022

Ok, the failing docs issue is caused by #4995, so I'm going to merge. I guess the rest aren't running because no non-docs files are touched. Neat!

@jni jni merged commit 5a5392d into napari:main Aug 31, 2022
@Carreau Carreau added this to the 0.4.17 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants