Use not mutable fields on Viewer where appropriate #2346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the release of pydantic 1.8.x and pydantic/pydantic#2196 we can now use field not mutable fields where appropriate on our Viewer. This will prevent people from overwriting the dims, or trying to set things that cannot be set. We also won't add event emitters for these fields as they cannot be changed.
Technically this is a breaking change, but I'm not quite sure how anyone would have successfully set these things before!
It should be reviewed after we fix our CI with
1.8.1
(see #2322). Note this will bump our min pydantic requirement to1.8.1
asallow_mutation=False
was previously not supported.Type of change