Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pillow dependency pin #1172

Merged
merged 1 commit into from Apr 26, 2020
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Apr 26, 2020

Description

As Pillow is an indirect dependency, remove the pin added in #1146.

python-pillow/Pillow#4528 was released in Pillow 7.1.2 yesterday: https://pillow.readthedocs.io/en/stable/releasenotes/7.1.2.html

Alternatively, you could keep the pin with:

Pillow!=7.1.0,!=7.1.1

or

Pillow>=7.1.2

Type of change

  • Bug-fix (non-breaking change which fixes an issue)

References

How has this been tested?

  • all tests pass with my change

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation
  • [n/a] I have added tests that prove my fix is effective or that my feature works

@tlambert03
Copy link
Member

Thanks @hugovk! I made the (incorrect) assumption that the next version was gonna be 7.2 (based on the 7.2.dev0 version I saw somewhere.). Since I'm fairly certain that a lot of napari functions will be broken if someone happens to end up with 7.1.0 or 7.1.1 (and so as to maintain backwargs compatibility), I think I'd prefer Pillow!=7.1.0,!=7.1.1. Would you mind updating this PR, and then I can merge it?

@hugovk hugovk changed the title Remove Pillow dependency pin Update Pillow dependency pin Apr 26, 2020
@hugovk
Copy link
Contributor Author

hugovk commented Apr 26, 2020

Thanks @hugovk! I made the (incorrect) assumption that the next version was gonna be 7.2 (based on the 7.2.dev0 version I saw somewhere.).

You made the correct assumption! 7.2.0 would be the next scheduled quarterly release (July 2020) and 7.2.dev0 is in the master branch.

Because this was affecting quite a few projects, we made a 7.1.2 point release.

Since I'm fairly certain that a lot of napari functions will be broken if someone happens to end up with 7.1.0 or 7.1.1 (and so as to maintain backwards compatibility), I think I'd prefer Pillow!=7.1.0,!=7.1.1. Would you mind updating this PR, and then I can merge it?

Good idea, updated!

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! and thanks for coming by to let us know! :)

@tlambert03 tlambert03 merged commit 134a7dc into napari:master Apr 26, 2020
@sofroniewn sofroniewn added this to the 0.3.0 milestone Apr 26, 2020
@sofroniewn sofroniewn added the bug Something isn't working label Apr 26, 2020
@hugovk hugovk deleted the rm-pillow-pin branch April 26, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants