Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/Remove CallDefault #6257

Closed
Carreau opened this issue Sep 24, 2023 · 1 comment · Fixed by #6901
Closed

Deprecate/Remove CallDefault #6257

Carreau opened this issue Sep 24, 2023 · 1 comment · Fixed by #6901
Labels
good first issue Good for newcomers task

Comments

@Carreau
Copy link
Contributor

Carreau commented Sep 24, 2023

🧰 Task

In napari/utils/misc.py, CallDefault seem to not be used since #2266. We should investigate adding a deprecation message and thinking about removal if this is not used anywhere else.

@MarchisLost
Copy link
Contributor

Hopefully this is what you wanted. Let me know if there is something wrong or incomplete.

melonora added a commit that referenced this issue May 16, 2024
…#6257 (#6901)

# References and relevant issues

Partly closes #6257 by adding a deprecation message to the CallDefault
function that seems to not be used since
#2266

# Description


- [X] - My PR is the minimum possible work for the desired functionality
- [ ] - I have commented my code, particularly in hard-to-understand
areas
- [ ] - I have made corresponding changes to docstrings and
documentation (open a PR on the docs repository
(https://github.com/napari/docs) if relevant!)
- [ ] - I have added tests that prove my fix is effective or that my
feature works
- [X] - If I included new strings, I have used `trans._("some string")`
to make them localizable.
(For more information see our [translations
guide](https://napari.org/developers/translations.html)).

---------

Co-authored-by: MarchisLost <davipinto15@gmail.com>
Co-authored-by: Wouter-Michiel Vierdag <w-mv@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants