Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycombo preview in settings does not respect platform #5047

Closed
alisterburt opened this issue Sep 8, 2022 · 4 comments · Fixed by #5064 or #5604
Closed

keycombo preview in settings does not respect platform #5047

alisterburt opened this issue Sep 8, 2022 · 4 comments · Fixed by #5064 or #5604
Labels
bug Something isn't working

Comments

@alisterburt
Copy link
Contributor

🐛 Bug

Editing a keyboard shortcut in the preferences dialog shows 'Control' while editing then resolves to the platform specific '⌘' when the combo has been entered -> it would be nice if what was seen when editing already matched the platform specific keys

To Reproduce

Steps to reproduce the behavior:

  1. open napari on macos
  2. preferences -> shortcuts
  3. edit keybinding to something using ⌘ key
@alisterburt alisterburt added the bug Something isn't working label Sep 8, 2022
Carreau added a commit to Carreau/napari that referenced this issue Sep 12, 2022
@Carreau
Show platform specific shortcut while editing.
0f467b3 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
@Carreau Carreau mentioned this issue Sep 12, 2022
Merged
12 tasks
@Carreau
Copy link
Contributor

Carreau commented Sep 12, 2022

See #5064 that should fix it.

Carreau added a commit to Carreau/napari that referenced this issue Sep 28, 2022
@Carreau
Show platform specific shortcut while editing.
db3d954 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue Oct 5, 2022
@Carreau
Show platform specific shortcut while editing.
3741a62 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue Nov 1, 2022
@Carreau
Show platform specific shortcut while editing.
e17555e 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
@psobolewskiPhD

This comment was marked as off-topic.

Sign in to view
@psobolewskiPhD

This comment was marked as off-topic.

Sign in to view
@psobolewskiPhD

This comment was marked as off-topic.

Sign in to view
Carreau added a commit to Carreau/napari that referenced this issue Nov 16, 2022
@Carreau
Show platform specific shortcut while editing.
6bb70fc 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue Feb 22, 2023
@Carreau
Show platform specific shortcut while editing.
e77db5c 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
@kne42 kne42 mentioned this issue Mar 8, 2023
Merged
Carreau added a commit to Carreau/napari that referenced this issue Apr 4, 2023
@Carreau
Show platform specific shortcut while editing.
b366e33 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue Apr 4, 2023
@Carreau
Show platform specific shortcut while editing.
1b6c2cd 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue Apr 21, 2023
@Carreau
Show platform specific shortcut while editing.
6056054 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue May 5, 2023
@Carreau
Show platform specific shortcut while editing.
2b249f6 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue Jun 14, 2023
@Carreau
Show platform specific shortcut while editing.
e369fb7 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
@jni jni closed this as completed in #5604 Jun 22, 2023
jni pushed a commit that referenced this issue Jun 22, 2023
@kne42
fix various keybinding/shortcut bugs (#5604)
29a19c1 
This PR addresses bugs where the improper symbols would be displayed for
e.g. ⌘V on Macs, as well as improper capturing on Macs where e.g.
Control would be read as Meta and vice versa. This relies on an upstream
fix in `app-model` and uses the logic there to properly capture the
correct modifier keys, regardless of if Qt is switching Control with
Meta or not.

fixes #5047 
fixes #5332 
fixes #5579 

depends on pyapp-kit/app-model#82
Carreau added a commit to Carreau/napari that referenced this issue Jun 22, 2023
@Carreau
Show platform specific shortcut while editing.
0a27e53 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue Jun 23, 2023
@Carreau
Show platform specific shortcut while editing.
d9856d3 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
Carreau added a commit to Carreau/napari that referenced this issue Jun 23, 2023
@Carreau
Show platform specific shortcut while editing.
6f7d969 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific
to canonical representation

Closes napari#5047
melissawm pushed a commit to melissawm/napari that referenced this issue Jul 3, 2023
@kne42 @melissawm
fix various keybinding/shortcut bugs (napari#5604)
aef0f67 
This PR addresses bugs where the improper symbols would be displayed for
e.g. ⌘V on Macs, as well as improper capturing on Macs where e.g.
Control would be read as Meta and vice versa. This relies on an upstream
fix in `app-model` and uses the logic there to properly capture the
correct modifier keys, regardless of if Qt is switching Control with
Meta or not.

fixes napari#5047 
fixes napari#5332 
fixes napari#5579 

depends on pyapp-kit/app-model#82
jni pushed a commit that referenced this issue Jul 7, 2023
@Carreau
Show platform specific shortcut while editing. (#5064)
5ce6fc9 
As the text in the text field is used to bind the shortcut later
introduce a utility function to parse back from platform specific to
canonical representation

Closes #5047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@Carreau @alisterburt @psobolewskiPhD