Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isort version in pre-commit config #151

Closed
wants to merge 1 commit into from

Conversation

aganders3
Copy link
Contributor

The previous version was failing to install due to some issues with poetry. See PyCQA/isort#2078.

@aganders3
Copy link
Contributor Author

Then again, now that napari is using ruff for this, perhaps that should be used in the plugin cookiecutter as well.

N.B. @Czaki

@Czaki
Copy link
Contributor

Czaki commented Feb 9, 2023

I'm not sure as ruff is really fast in development and adding new rules.

I'm not against but it will require to preciselly preselect enabled rules and revisit it time to time.

@aganders3
Copy link
Contributor Author

Thanks for the input. I can see it both ways. On one hand pre-commit is basically pinning a version, so the fast changes shouldn't be a problem. On the other, I think we can expect many to use pre-commit autoupdate.

@Czaki
Copy link
Contributor

Czaki commented Mar 16, 2023

at this moment, I prefer to switch to ruff with removing flake and isort. It provides a much better user experience.

@aganders3
Copy link
Contributor Author

Sounds good - I will close this then!

@aganders3 aganders3 closed this Mar 16, 2023
@aganders3 aganders3 deleted the patch-2 branch March 16, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants