Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows tests #143

Merged
merged 6 commits into from
Jan 15, 2023
Merged

Fix windows tests #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a151782
try to fix windows test fails
psobolewskiPhD Nov 22, 2022
d2ae7cc
fix depend
psobolewskiPhD Nov 22, 2022
dc97444
fix test action?
psobolewskiPhD Nov 22, 2022
9ebd112
Try to use the right depend (branch with fix)
psobolewskiPhD Nov 22, 2022
90fd487
use PR branch
psobolewskiPhD Nov 22, 2022
c3c931c
use PR branch in tox.ini
psobolewskiPhD Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pytest pytest-cookies tox
pip install pytest tox
pip install git+https://github.com/hackebrot/pytest-cookies.git@refs/pull/61/head

- name: Test
uses: GabrielBB/xvfb-action@v1
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ toxworkdir = /tmp/.tox

[testenv]
deps = pytest
pytest-cookies
git+https://github.com/hackebrot/pytest-cookies.git@refs/pull/61/head
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we want to switch to this branch globally or only for windows?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Good question. I'm not sure. Maybe all tests, because it reflects the situation once--eventually--the upstream PR is merged? But I can see it either way.

tox
commands = pytest -v {posargs:tests}

Expand Down