Switch to rpcclient based on current upstream Conformal #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
JeremyRand
force-pushed
the
conformal-rpcclient
branch
from
4f301f6
to
72ccb06
Compare
|
Fixed merge conflict. |
JeremyRand
force-pushed
the
conformal-rpcclient
branch
2 times, most recently
from
1264657
to
79d694d
Compare
5 tasks
JeremyRand
added a commit
that referenced
this pull request
Oct 19, 2019
06d6efb backend: Stream-isolate LRU cache (JeremyRand) ed8fa68 Add plumbing for stream isolation (JeremyRand) Pull request description: This PR adds the plumbing for stream isolation (from madns to namecoin, without passing the stream ID to namecoind), and stream-isolates the LRU cache. A follow-up PR will pass the stream ID to namecoind; that's currently blocked on #103 . Prerequisites: - [x] Merge hlandau/madns#4 - [x] Merge hlandau/madns#5 - [x] Tag a madns release (with major version 2). - [x] Replace `madns.v1` dependency with `madns.v2`. - [x] Tag a madns release (with hlandau/madns#5 included). ACKs for commit 06d6ef: Tree-SHA512: ee385454aef3b802899659db74bbeb28ec6555216f4a4ccfc6047c08f32272080b7f76f851e4b291204ab41525bbfae30e7cdc663b49595d7d5105744810c763
JeremyRand
force-pushed
the
conformal-rpcclient
branch
2 times, most recently
from
593e212
to
4740b2e
Compare
JeremyRand
changed the title
JeremyRand
changed the title
JeremyRand
force-pushed
the
conformal-rpcclient
branch
from
4740b2e
to
7ec83b6
Compare
|
Triggering a rebuild.. |
JeremyRand
force-pushed
the
conformal-rpcclient
branch
from
7ec83b6
to
f0f518a
Compare
We will switch to upstream once they merge our patches.
JeremyRand
force-pushed
the
conformal-rpcclient
branch
from
f0f518a
to
2b1eed8
Compare
|
Upstream delays have reached the point where continuing to block will mean our funding will grind to a halt. Since the status quo is a fork of Conformal, switching to a more recent fork of Conformal doesn't make anything worse, and will allow us to move forward with funded projects. This PR is therefore modified to point to a Namecoin fork of Conformal's repo. We will continue to work with Conformal to rectify the situation long-term, but for now we're going to merge this as-is. |
JeremyRand
added a commit
that referenced
this pull request
Oct 27, 2019
2b1eed8 Switch to new rpcclient based on latest upstream Conformal (JeremyRand) Pull request description: Namecoin's fork of Conformal's RPC client library is ancient and unmaintained; switching to upstream eliminates a major source of potential bugs (and known bugs, e.g. the ConsensusJ and Electrum compatibility bugs that we had to patch). Fixes #9 TODO: - [ ] Wait for Conformal to merge btcsuite/btcd#1457 - [ ] Wait for Conformal to merge btcsuite/btcd#1460 - [x] Push `name_show` support for `ncjson` and `ncrpcclient` - [x] Implement cookie authentication - [x] Test cookie authentication ACKs for commit 2b1eed: Tree-SHA512: 157780613661af240d83a78d66386c66fcfeed0700088d263a20389c45b200db1b651ea985f345de2ac2f250bdafcc4cd5901579e9f5a97ddc13e77e7a7bcf39
JeremyRand
added a commit
that referenced
this pull request
Oct 28, 2019
539bc89 ncdumpzone: Work around encoding errors (JeremyRand) Pull request description: Fixes #105 TODO: - [x] Merge #103 (this PR will then need a rebase) ACKs for commit 539bc8: Tree-SHA512: 5762687077ea2611cd7939dd49d337346b212a91442b32f7be5ac592e2580029bc0e63c4e6597b2685495de59a431fe422048fc3a1f0d52fb678e377eb947401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namecoin's fork of Conformal's RPC client library is ancient and unmaintained; switching to upstream eliminates a major source of potential bugs (and known bugs, e.g. the ConsensusJ and Electrum compatibility bugs that we had to patch).
Fixes #9
TODO:
name_showsupport forncjsonandncrpcclient