Skip to content

Commit

Permalink
mac build: bundle old PyQt5 so that .app runs on macOS 11 "Big Sur"
Browse files Browse the repository at this point in the history
This is the time of the year Apple breaks our mac builds, as usual.
mac now has its own "binaries" requirements. This allows us to use
an older version of PyQt5 in the mac binaries. For some reason
if we bundle newer PyQt5, the built app will not start on macOS 11
(but will on older macOS).

related: spesmilo#6461
in particular, see spesmilo#6461 (comment)
  • Loading branch information
SomberNight authored and JeremyRand committed May 7, 2021
1 parent b57284d commit 9196027
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion contrib/freeze_packages.sh
Expand Up @@ -20,7 +20,7 @@ which virtualenv > /dev/null 2>&1 || { echo "Please install virtualenv" && exit

${SYSTEM_PYTHON} -m hashin -h > /dev/null 2>&1 || { ${SYSTEM_PYTHON} -m pip install hashin; }

for i in '' '-hw' '-binaries' '-build-wine' '-build-mac' '-build-sdist' '-build-appimage'; do
for i in '' '-hw' '-binaries' '-binaries-mac' '-build-wine' '-build-mac' '-build-sdist' '-build-appimage'; do
rm -rf "$venv_dir"
virtualenv -p ${SYSTEM_PYTHON} $venv_dir

Expand Down
2 changes: 1 addition & 1 deletion contrib/osx/make_osx
Expand Up @@ -136,7 +136,7 @@ python3 -m pip install --no-dependencies -Ir ./contrib/deterministic-build/requi
|| fail "Could not install hardware wallet requirements"

info "Installing dependencies specific to binaries..."
python3 -m pip install --no-dependencies -Ir ./contrib/deterministic-build/requirements-binaries.txt --user \
python3 -m pip install --no-dependencies -Ir ./contrib/deterministic-build/requirements-binaries-mac.txt --user \
|| fail "Could not install dependencies specific to binaries"

info "Building $PACKAGE..."
Expand Down
2 changes: 2 additions & 0 deletions contrib/requirements/requirements-binaries-mac.txt
@@ -0,0 +1,2 @@
PyQt5<5.13.2
cryptography>=2.1

0 comments on commit 9196027

Please sign in to comment.