New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update controller-runtime to v0.12.3 #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakamasato
changed the title
fix(deps): update kubernetes packages to v0.24.3
fix(deps): update controller-runtime to v0.12.3
Aug 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 75.68% 73.92% -1.77%
==========================================
Files 5 5
Lines 292 395 +103
==========================================
+ Hits 221 292 +71
- Misses 53 77 +24
- Partials 18 26 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nakamasato
force-pushed
the
upgrade-controller-runtime
branch
from
August 21, 2022 12:40
5ecec4a
to
9012849
Compare
nakamasato
force-pushed
the
upgrade-controller-runtime
branch
2 times, most recently
from
March 11, 2023 23:08
06523ea
to
ddf79c5
Compare
nakamasato
force-pushed
the
upgrade-controller-runtime
branch
from
March 11, 2023 23:37
8d993a5
to
3fef452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail to run
make test
Error1
Fixed by b5fa53c
Error2
fixed by
golang-lint
Fixed by 9012849
Other changes
PingContext
to make it time out quickly if mysql is not available https://pkg.go.dev/database/sql#DB.PingContext