Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extConfig未配置的属性,继承主配置 #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mayyamus
Copy link

@mayyamus mayyamus commented Mar 7, 2020

extConfig未配置的属性,继承主配置。在extConfig减少配置重复的基础参数

@mayyamus mayyamus changed the title extConfig未配置的属性,继承主配置,减少配置参数 extConfig未配置的属性,继承主配置 Mar 7, 2020
@chuntaojun
Copy link
Member

I might not be able to unify this pr, because we would prefer the user to actively choose which configurations need to be enabled to refresh, which might incur additional and pointless overhead if you follow the master configuration

@mayyamus
Copy link
Author

mayyamus commented Mar 7, 2020

I might not be able to unify this pr, because we would prefer the user to actively choose which configurations need to be enabled to refresh, which might incur additional and pointless overhead if you follow the master configuration

在使用的过程中,发现大多数参数(如serverAddr)都是一样的,这样可以更加简洁。如果需要不同的参数可以明确配置。

@chuntaojun
Copy link
Member

I might not be able to unify this pr, because we would prefer the user to actively choose which configurations need to be enabled to refresh, which might incur additional and pointless overhead if you follow the master configuration

在使用的过程中,发现大多数参数(如serverAddr)都是一样的,这样可以更加简洁。如果需要不同的参数可以明确配置。

Yes, but that's just the meta configuration data for nacos, the configuration information for the configuration file, or the user declaration

@chuntaojun
Copy link
Member

For example, it is not recommended to actively inherit the Settings of the master configuration if the configuration turns on auto refresh

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jh.ma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants