Handle case for when object to serialize is of bytes type, fixes #380 #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug in #380. The issue was a bytes object not being handled in
_CustomJsonEncoder
. You can also fix this here:sslyze/sslyze/utils/tls_wrapped_protocol_helpers.py
Line 257 in c77ed63
by explicitly passing a string by decoding
self.ERR_NO_STARTTLS
. I'm not sure which method you'd prefer.I can add a test too if it's helpful - let me know what you think!
I forgot to post the command I used to reproduce the bug:
sslyze/__main__.py --tlsv1_2 --json_out=- --starttls=imap imap-mail.outlook.com:110
and the result I get after the update: