* flip operands to make param newValue preceding oldValue @ (Sub)…

…ReplySaver.cs

* split into two partial classes @ ReplySaver.cs
@ crawler

* reorder methods
* expand list with newline
@ c#

c#/crawler/src/Tieba/Crawl/Crawler/ThreadCrawler.cs

@@ -48,11 +48,10 @@ protected override IEnumerable<Request> GetRequestsForPage(Page page, Cancellati
         ];
     }
 
-    protected ThreadRequest.Types.Data GetRequestDataForClientVersion602(Page page) =>
-        new()
-        {
-            Kw = forumName,
-            Pn = (int)page,
-            Rn = 30
-        };
+    protected ThreadRequest.Types.Data GetRequestDataForClientVersion602(Page page) => new()
+    {
+        Kw = forumName,
+        Pn = (int)page,
+        Rn = 30
+    };
 }

c#/crawler/src/Tieba/Crawl/Parser/UserParser.cs

@@ -17,7 +17,13 @@ public partial class UserParser(ConcurrentDictionary<Uid, User> users)
             var (portrait, portraitUpdatedAt) = ExtractPortrait(el.Portrait);
             if (uid < 0) // historical anonymous user
             {
-                return new() {Uid = uid, Name = el.NameShow, Portrait = portrait, PortraitUpdatedAt = portraitUpdatedAt};
+                return new()
+                {
+                    Uid = uid,
+                    Name = el.NameShow,
+                    Portrait = portrait,
+                    PortraitUpdatedAt = portraitUpdatedAt
+                };
             }
 
             // will be an empty string when the user hasn't set a username for their baidu account yet

c#/crawler/src/Tieba/Crawl/Saver/Post/ReplySaver.cs

@@ -2,7 +2,7 @@
 
 namespace tbm.Crawler.Tieba.Crawl.Saver;
 
-public class ReplySaver(
+public partial class ReplySaver(
         ILogger<ReplySaver> logger,
         ConcurrentDictionary<PostId, ReplyPost> posts,
         ReplySignatureSaver replySignatureSaver,
@@ -21,13 +21,13 @@ protected override bool FieldUpdateIgnorance
 
     protected override bool UserFieldUpdateIgnorance(string propName, object? oldValue, object? newValue) => propName switch
     { // FansNickname in reply response will always be null
-        nameof(User.FansNickname) when oldValue is not null && newValue is null => true,
+        nameof(User.FansNickname) when newValue is null && oldValue is not null => true,
         _ => false
     };
 
     protected override bool UserFieldRevisionIgnorance(string propName, object? oldValue, object? newValue) => propName switch
     { // user icon will be null after UserParser.ResetUsersIcon() get invoked
-        nameof(User.Icon) when oldValue is null && newValue is not null => true,
+        nameof(User.Icon) when newValue is not null && oldValue is null => true,
         _ => false
     };
 
@@ -51,6 +51,15 @@ protected override bool FieldUpdateIgnorance
         }
     };
 
+    [SuppressMessage("StyleCop.CSharp.SpacingRules", "SA1025:Code should not contain multiple whitespace in a row")]
+    protected override NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => fieldName switch
+    {
+        nameof(ReplyPost.IsFold)        => 1 << 2,
+        nameof(ReplyPost.DisagreeCount) => 1 << 4,
+        nameof(ReplyPost.Geolocation)   => 1 << 5,
+        _ => 0
+    };
+
     public override SaverChangeSet<ReplyPost> Save(CrawlerDbContext db)
     {
         var changeSet = Save(db, r => r.Pid,
@@ -65,16 +74,9 @@ public override SaverChangeSet<ReplyPost> Save(CrawlerDbContext db)
 
         return changeSet;
     }
-
-    [SuppressMessage("StyleCop.CSharp.SpacingRules", "SA1025:Code should not contain multiple whitespace in a row")]
-    protected override NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => fieldName switch
-    {
-        nameof(ReplyPost.IsFold)        => 1 << 2,
-        nameof(ReplyPost.DisagreeCount) => 1 << 4,
-        nameof(ReplyPost.Geolocation)   => 1 << 5,
-        _ => 0
-    };
-
+}
+public partial class ReplySaver
+{
     private static void SaveReplyContentImages(CrawlerDbContext db, IEnumerable<ReplyPost> replies)
     {
         var pidAndImageList = (

c#/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs

@@ -18,7 +18,7 @@ protected override bool UserFieldUpdateIgnorance
         nameof(User.Icon) => true,
 
         // FansNickname in sub reply response will always be null
-        nameof(User.FansNickname) when oldValue is not null && newValue is null => true,
+        nameof(User.FansNickname) when newValue is null && oldValue is not null => true,
 
         // DisplayName in users embedded in sub replies from response will be the legacy nickname
         nameof(User.DisplayName) => true,
@@ -40,6 +40,8 @@ protected override bool UserFieldUpdateIgnorance
         }
     };
 
+    protected override NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => 0;
+
     public override SaverChangeSet<SubReplyPost> Save(CrawlerDbContext db)
     {
         var changeSet = Save(db, sr => sr.Spid,
@@ -52,6 +54,4 @@ public override SaverChangeSet<SubReplyPost> Save(CrawlerDbContext db)
 
         return changeSet;
     }
-
-    protected override NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => 0;
 }

c#/crawler/src/Tieba/Crawl/Saver/Post/ThreadSaver.cs

@@ -67,11 +67,6 @@ protected override bool UserFieldUpdateIgnorance
         }
     };
 
-    public override SaverChangeSet<ThreadPost> Save(CrawlerDbContext db) =>
-        Save(db, th => th.Tid,
-            th => new ThreadRevision {TakenAt = th.UpdatedAt ?? th.CreatedAt, Tid = th.Tid},
-            PredicateBuilder.New<ThreadPost>(th => Posts.Keys.Contains(th.Tid)));
-
     [SuppressMessage("StyleCop.CSharp.SpacingRules", "SA1025:Code should not contain multiple whitespace in a row")]
     protected override NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => fieldName switch
     {
@@ -86,4 +81,9 @@ protected override bool UserFieldUpdateIgnorance
         nameof(ThreadPost.Geolocation)      => 1 << 10,
         _ => 0
     };
+
+    public override SaverChangeSet<ThreadPost> Save(CrawlerDbContext db) =>
+        Save(db, th => th.Tid,
+            th => new ThreadRevision {TakenAt = th.UpdatedAt ?? th.CreatedAt, Tid = th.Tid},
+            PredicateBuilder.New<ThreadPost>(th => Posts.Keys.Contains(th.Tid)));
 }

c#/shared/src/Db/TbmDbContext.cs

@@ -139,9 +139,7 @@ protected override void OnModelCreating(ModelBuilder b)
         b.Entity<ReplyContentImage>().ToTable($"tbmc_f{fid}_reply_content_image");
 
     protected virtual void OnConfiguringNpgsql(NpgsqlDbContextOptionsBuilder builder) { }
-
     protected virtual void OnBuildingNpgsqlDataSource(NpgsqlDataSourceBuilder builder) { }
-
     private Lazy<NpgsqlDataSource> GetNpgsqlDataSource(string? connectionString) =>
         _dataSourceSingleton ??= new(() =>
         {