+ extension method IEnumerable<IEnumerable<>>.Flatten2() to simplif…

…y `.SelectMany(i => i)`, the other extension method with name `Flatten()` already taken by language-ext https://github.com/louthy/language-ext/blob/2328e0732b3579f29ae3c52c570760fdeae8e9d2/LanguageExt.Core/Immutable%20Collections/Arr/Arr.Extensions.cs#L19 @ ExtensionMethods.cs

@ c#/shared

c#/crawler/src/Worker/ForumModeratorRevisionCrawlWorker.cs

@@ -50,7 +50,7 @@ where e.IsCrawling
                     ?.GetAttribute("href")?.Split("/home/main?id=")[1].NullIfEmpty())
                 .OfType<string>();
             return memberPortraits.Select(portrait => (type, portrait));
-        }).SelectMany(i => i);
+        }).Flatten2();
     }
 
     private async Task Save(

c#/imagePipeline/src/Consumer/HashConsumer.cs

@@ -91,7 +91,7 @@ static byte[] GetThumbHashForMatrix(Mat mat)
             return rgbaMat.GetArray(out Vec4b[] pixels)
                 ? ThumbHashes.Utilities.RgbaToThumbHash(mat.Width, mat.Height, pixels
                     .Select(vec => new[] {vec.Item0, vec.Item1, vec.Item2, vec.Item3})
-                    .SelectMany(i => i).ToArray())
+                    .Flatten2().ToArray())
                 : throw new InvalidOperationException("Failed to convert matrix into byte array.");
         }
     };

c#/imagePipeline/src/Consumer/QrCodeConsumer.cs

@@ -29,7 +29,7 @@ public QrCodeConsumer(IConfiguration config, FailedImageHandler failedImageHandl
                 imageKeyWithMatrix => imageKeyWithMatrix.ImageId,
                 ScanQrCodeInImage)
             .ToList();
-        db.ImageQrCodes.AddRange(imageQrCodeEithers.Rights().SelectMany(i => i));
+        db.ImageQrCodes.AddRange(imageQrCodeEithers.Rights().Flatten2());
         return imageQrCodeEithers.Lefts();
     }
 

c#/imagePipeline/src/ImageBatchConsumingWorker.cs

@@ -109,7 +109,7 @@ void MarkImagesInReplyAsConsumed
                     .Where(i => i.ImageInReply is not {HashConsumed: true, QrCodeConsumed: true, OcrConsumed: true}),
                 imageWithBytes => imageWithBytes.ImageInReply.ImageId,
                 DecodeImageOrFramesBytes(stoppingToken))
-            .Rights().SelectMany(i => i).ToList();
+            .Rights().Flatten2().ToList();
         try
         {
             IReadOnlyCollection<ImageKeyWithMatrix> ExceptConsumed
@@ -200,7 +200,7 @@ ImageKeyWithMatrix DecodeFrame(ImageFrame<Rgb24> frame, int frameIndex)
         var scriptGroupings = await forumScripts.AsNoTracking()
             .GroupBy(e => e.Fid, e => e.Script)
             .ToListAsync(stoppingToken);
-        var scripts = scriptGroupings.SelectMany(i => i).Distinct().ToList();
+        var scripts = scriptGroupings.Flatten2().Distinct().ToList();
         var recognizedTextLinesKeyByScript = new Dictionary<string, List<ImageOcrLine>>(scripts.Count);
         scripts.ForEach(script => recognizedTextLinesKeyByScript[script] = []);
 

c#/imagePipeline/src/Ocr/JointRecognizer.cs

@@ -42,10 +42,10 @@ public class JointRecognizer(
         var detectedEithers = _paddleOcrProvider
             .DetectMatrices(matricesKeyByImageKey, failedImageHandler, stoppingToken).ToList();
         var recognizedResultsViaPaddleOcr =
-            recognizedEithersViaPaddleOcr.Rights().SelectMany(i => i).ToList();
+            recognizedEithersViaPaddleOcr.Rights().Flatten2().ToList();
         var recognizedEithersViaTesseract = RecognizeMatricesViaTesseract(
                 recognizedResultsViaPaddleOcr,
-                detectedEithers.Rights().SelectMany(i => i).ToList(),
+                detectedEithers.Rights().Flatten2().ToList(),
                 matricesKeyByImageKey,
                 stoppingToken)
             .ToList();

c#/shared/src/ExtensionMethods.cs

@@ -46,6 +46,9 @@ public static void AddRange<T>(this ICollection<T> list, IEnumerable<T> items)
         this IEnumerable<KeyValuePair<TKey, TValue>> first,
         IEnumerable<TKey> second) =>
         first.IntersectBy(second, pair => pair.Key);
+
+    public static IEnumerable<T> Flatten2<T>(this IEnumerable<IEnumerable<T>> source) =>
+        source.SelectMany(i => i);
 }
 public static partial class ExtensionMethods
 {