Fast bao tree #1322
Merged
Fast bao tree #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dignifiedquire
approved these changes
Aug 3, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the newly published iroh-blake3 and bao-tree to get much faster hashing of 16kb subtrees. Factor of 4 improvement due to SIMD use in blake3.
Ideally we would move back to upstream blake3 eventually, once BLAKE3-team/BLAKE3#329 is merged.
To make the switch and the subsequent switch back easier I removed the dependency on blake3 and instead reexported our forked blake3 as blake3 in bao-tree.
Notes & open questions
Is there a nicer way to do all this reexport business?
Change checklist